Skip to main content

Why should I require all subclasses to call super() if I can use getmro to do it automatically?

I've read many of the other questions and opinions about super like super-harmful and super-considered-super but none of them mention inspect.getmro as an alternative. I'm wondering, instead of implementing a class hierarchy like this:

class Base(object):
  def __init__(self, **kwargs):
    print("base init")

class A(Base):
  def __init__(self, **kwargs):
    super(A, self).__init__()
    print("a init")

class B(Base):
  def __init__(self, **kwargs):
    super(B, self).__init__()
    print("b init")

class C(A, B):
  def __init__(self, **kwargs):
    super(C, self).__init__()
    print("c init")

Why don't we do something like this?

import inspect

class Base(object):
  def __init__(self, **kwargs):
    mro = inspect.getmro(self.__class__)

    for mro_cls in reversed(mro):
      if hasattr(mro_cls, "_init"):
        mro_cls._init(self, **kwargs)

  def _init(self, **kwargs):
    print("base")

class A(Base):
  def _init(self, **kwargs):
    print("a init")

class B(Base):
  def _init(self, **kwargs):
    print("b init")

class C(A, B):
  def _init(self, **kwargs):
    print("c init")

It seems like there are some potential benefits:

  • New developers can extend the hierarchy by implementing _init without additional boilerplate.
  • Enforce standard practices like initializing the parent class before the child for attribute overrides.

Are there any drawbacks that I'm missing?



source https://stackoverflow.com/questions/71132222/why-should-i-require-all-subclasses-to-call-super-if-i-can-use-getmro-to-do-it

Comments

Popular posts from this blog

How to show number of registered users in Laravel based on usertype?

i'm trying to display data from the database in the admin dashboard i used this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count(); echo $users; ?> and i have successfully get the correct data from the database but what if i want to display a specific data for example in this user table there is "usertype" that specify if the user is normal user or admin i want to user the same code above but to display a specific usertype i tried this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count()->WHERE usertype =admin; echo $users; ?> but it didn't work, what am i doing wrong? source https://stackoverflow.com/questions/68199726/how-to-show-number-of-registered-users-in-laravel-based-on-usertype

Confusion between commands.Bot and discord.Client | Which one should I use?

Whenever you look at YouTube tutorials or code from this website there is a real variation. Some developers use client = discord.Client(intents=intents) while the others use bot = commands.Bot(command_prefix="something", intents=intents) . Now I know slightly about the difference but I get errors from different places from my code when I use either of them and its confusing. Especially since there has a few changes over the years in discord.py it is hard to find the real difference. I tried sticking to discord.Client then I found that there are more features in commands.Bot . Then I found errors when using commands.Bot . An example of this is: When I try to use commands.Bot client = commands.Bot(command_prefix=">",intents=intents) async def load(): for filename in os.listdir("./Cogs"): if filename.endswith(".py"): client.load_extension(f"Cogs.{filename[:-3]}") The above doesnt giveany response from my Cogs ...

Why is my reports service not connecting?

I am trying to pull some data from a Postgres database using Node.js and node-postures but I can't figure out why my service isn't connecting. my routes/index.js file: const express = require('express'); const router = express.Router(); const ordersCountController = require('../controllers/ordersCountController'); const ordersController = require('../controllers/ordersController'); const weeklyReportsController = require('../controllers/weeklyReportsController'); router.get('/orders_count', ordersCountController); router.get('/orders', ordersController); router.get('/weekly_reports', weeklyReportsController); module.exports = router; My controllers/weeklyReportsController.js file: const weeklyReportsService = require('../services/weeklyReportsService'); const weeklyReportsController = async (req, res) => { try { const data = await weeklyReportsService; res.json({data}) console...