Skip to main content

Is my code okay or did I make it way too complicated?

I recently started coding and I love it. I'm currently working on a few tasks (for beginners lol) and just came up with the following: 'Find the second greatest element in a list'

I did the following:

def second_greatest(list):
    length = len(list)
    if length <= 1:
        return(list)
    else:
        greatest = max(list[0], list[1])
        s_greatest = min(list[0], list[1])
        for i in range (2, length):
            if list[i] > greatest:
                s_greatest = greatest
                greatest = list[i]
            elif list[i] > s_greatest and greatest != list[i]:
                s_greatest= list[i]

        return(s_greatest)

I found this solution on the web:

def example(example_list, k):
    for i in range(k-1):
        example_list.remove(max(example_list))
    return (max(example_list))

I feel like an idiot, because my code looks too complicated compared to the second one... If we have a relatively large number (e.g. find 1438th greatest), I would definitely go with solution 2.. But I'm wondering which solution is better (faster) for this particular question (find second greatest value)?



source https://stackoverflow.com/questions/71832779/is-my-code-okay-or-did-i-make-it-way-too-complicated
Labels:

Comments

Post a Comment

Popular posts from this blog

Where and how is this Laravel kernel constructor called? [closed]

Where and how is this Laravel kernel constructor called? public fucntion __construct(Application $app, $Router $roouter) { } I have read the documentation and some online tutorial but I can find any clear explanation. I am learning Laravel and I am wondering where does this kernel constructor receives its arguments from. "POSTMOTERM" CLARIFICATION: Here is more clarity.I have checked the boostrap/app.php and it is only used for boostrapping the interfaces into the container class. What is not clear to me is where and how the Kernel class is instatiated and the arguments passed to the object calling the constructor.Something similar to; obj = new kernel(arg1,arg2) or, is the framework using some magic functions somewhere? Special gratitude to those who burn their eyeballs and brain cells on this trivia before it goes into a full blown menopause alias "MARKED AS DUPLICATE". To some of the itchy-finger keyboard warriors, a.k.a The mods,because I believe in th...
Post a Comment
Read more

Why is my reports service not connecting?

I am trying to pull some data from a Postgres database using Node.js and node-postures but I can't figure out why my service isn't connecting. my routes/index.js file: const express = require('express'); const router = express.Router(); const ordersCountController = require('../controllers/ordersCountController'); const ordersController = require('../controllers/ordersController'); const weeklyReportsController = require('../controllers/weeklyReportsController'); router.get('/orders_count', ordersCountController); router.get('/orders', ordersController); router.get('/weekly_reports', weeklyReportsController); module.exports = router; My controllers/weeklyReportsController.js file: const weeklyReportsService = require('../services/weeklyReportsService'); const weeklyReportsController = async (req, res) => { try { const data = await weeklyReportsService; res.json({data}) console...
Post a Comment
Read more

How to show number of registered users in Laravel based on usertype?

i'm trying to display data from the database in the admin dashboard i used this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count(); echo $users; ?> and i have successfully get the correct data from the database but what if i want to display a specific data for example in this user table there is "usertype" that specify if the user is normal user or admin i want to user the same code above but to display a specific usertype i tried this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count()->WHERE usertype =admin; echo $users; ?> but it didn't work, what am i doing wrong? source https://stackoverflow.com/questions/68199726/how-to-show-number-of-registered-users-in-laravel-based-on-usertype
Post a Comment
Read more