Is my code okay or did I make it way too complicated?

I recently started coding and I love it. I'm currently working on a few tasks (for beginners lol) and just came up with the following: 'Find the second greatest element in a list'

I did the following:

def second_greatest(list):
    length = len(list)
    if length <= 1:
        return(list)
    else:
        greatest = max(list[0], list[1])
        s_greatest = min(list[0], list[1])
        for i in range (2, length):
            if list[i] > greatest:
                s_greatest = greatest
                greatest = list[i]
            elif list[i] > s_greatest and greatest != list[i]:
                s_greatest= list[i]

        return(s_greatest)

I found this solution on the web:

def example(example_list, k):
    for i in range(k-1):
        example_list.remove(max(example_list))
    return (max(example_list))

I feel like an idiot, because my code looks too complicated compared to the second one... If we have a relatively large number (e.g. find 1438th greatest), I would definitely go with solution 2.. But I'm wondering which solution is better (faster) for this particular question (find second greatest value)?

source https://stackoverflow.com/questions/71832779/is-my-code-okay-or-did-i-make-it-way-too-complicated

Comments

Why is my reports service not connecting?

I am trying to pull some data from a Postgres database using Node.js and node-postures but I can't figure out why my service isn't connecting. my routes/index.js file: const express = require('express'); const router = express.Router(); const ordersCountController = require('../controllers/ordersCountController'); const ordersController = require('../controllers/ordersController'); const weeklyReportsController = require('../controllers/weeklyReportsController'); router.get('/orders_count', ordersCountController); router.get('/orders', ordersController); router.get('/weekly_reports', weeklyReportsController); module.exports = router; My controllers/weeklyReportsController.js file: const weeklyReportsService = require('../services/weeklyReportsService'); const weeklyReportsController = async (req, res) => { try { const data = await weeklyReportsService; res.json({data}) console...

How to show number of registered users in Laravel based on usertype?

i'm trying to display data from the database in the admin dashboard i used this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count(); echo $users; ?> and i have successfully get the correct data from the database but what if i want to display a specific data for example in this user table there is "usertype" that specify if the user is normal user or admin i want to user the same code above but to display a specific usertype i tried this: <?php use Illuminate\Support\Facades\DB; $users = DB::table('users')->count()->WHERE usertype =admin; echo $users; ?> but it didn't work, what am i doing wrong? source https://stackoverflow.com/questions/68199726/how-to-show-number-of-registered-users-in-laravel-based-on-usertype

The number of nodes and edges I calculated manually and by a method provided by networkx library dont match

I am trying to analyse a graph using networkx library in Python. I have implemented a function that returns the nodes and edges of that graph. After that I counted the number of nodes and edges by implementing the len() function for nodes and edges, which gave me 17 for both nodes and edges. However, when I used the method graph.number_of_nodes() of networkx library it gave me 53. My code: import pandas as pd import networkx as nx import matplotlib.pyplot as plt header_list = ["a","b","w"] E =pd.read_csv("aves-barn-swallow-contact-network.edges",sep=" ",header= None,names=header_list) # print(E.head()) # prints first few rows of the csv file G = nx.from_pandas_edgelist(E,"a","b",["w"]) nx.draw(G) plt.show() class GraphAnalyse: #finding nodes and edges def nodeEdge(self,Graph): nodes = Graph.nodes() edges = Graph.edges() ...

StacksPedia

Search This Blog